chore: add more Ruff checks and fixes #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Nov 12, 2024
| @@ -278,6 +280,7 @@ def install_and_run_script( | |||
| silent=silent, | |||
| success_codes=success_codes, | |||
| external=None, | |||
| log=log, | |||
There was a problem hiding this comment.
This is a bug fix caught by the linting rules, it wasn't being passed through.
There was a problem hiding this comment.
Any chance this could affect the behavior?
There was a problem hiding this comment.
If it was passed, it was ignored before, now it will work as intended. It just affects logging, so it shouldn't break anyone. And this is a very new method, it was added last release.
henryiii
commented
Nov 12, 2024
henryiii
force-pushed
the
henryiii/chore/ruff
branch
from
e73fb12 to
0677321
Compare
DiddiLeija
approved these changes
Nov 22, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/ruff
branch
from
0677321 to
e91b74d
Compare
|
Thanks! I've rebased and also bumped to Ruff 0.8, which gets rid of one of our ignores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more checks. First commit is stable checks, and the second commit is some from preview (not activated, just fixed the issue if it looked useful).