Removed opening hours and added simple-opening-hours #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please review and merge it? |
mojoaxel
requested changes
Oct 24, 2020
There was a problem hiding this comment.
@Kishore-abhimanyu Thanks for trying to contribute!
- It is not enough to just replace one library with another, because they are not compatible. You also need to change the usage in the code.
- The test fail. Please make sure the CI turnes green after you changes.
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/wo-ist-markt/wo-ist-markt.github.io" | ||
| }, | ||
| "scripts": { | ||
| "scripts": { |
There was a problem hiding this comment.
This new whitespace should be removed.
There was a problem hiding this comment.
@Kishore-abhimanyu Do you need help with this?
There was a problem hiding this comment.
@Kishore-abhimanyu Are you still working on this?
There was a problem hiding this comment.
@mojoaxel Do you know the state of this pull request?
There was a problem hiding this comment.
🛎️ @Kishore-abhimanyu, @mojoaxel Last reminder before closing this.
|
I am now closing this issue due to inactivity over the last months. If anyone is interested in the topic we can re-open it at any time. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed opening hours and added simple-opening-hours