Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blurry toasts, heights store #83

Merged
merged 3 commits into from
Mar 30, 2024
Merged

fix: blurry toasts, heights store #83

merged 3 commits into from
Mar 30, 2024

Conversation

xxmichas
Copy link
Contributor

This PR addresses 2 issues:

  1. Blurry toasts:
    Press "Promise" button on repo's website and you will notice that once the promises resolve, toasts will be blurry.
    image
  2. Update existing height (for a given toastId) instead of adding a new one to the heights store.
    Press "Default" button on repo's website and expand the toaster. You will notice one of the toast's height is a couple pixels less than what it should be - 53.5px.
    image

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: e3ec6c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-sonner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 4:24pm

Copy link
Owner

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wobsoriano wobsoriano merged commit a6cc46a into wobsoriano:main Mar 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants