Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of FrontBase Plugin #510

Merged
merged 5 commits into from
Jan 15, 2014
Merged

Conversation

darkv
Copy link
Member

@darkv darkv commented Nov 18, 2013

This patch makes the following changes to the FrontBase Plugin:

  • SimpleDateFormatters were created every time an attribute had to be formatted, now those formatters are created only once per thread (using ThreadLocal as SimpleDateFormat is not thread safe)
  • the class FrontBaseTypes exists in Wonder but apparently was nowhere used. As it makes sense to separate that data from the quite big plugin class those are used in favor
  • add some generics

The value type constants as well as the method internalTypeForExternal(…) within the plugin class are only deprecated as there could be users subclassing the plugin and using them. With a later Wonder release those should be removed eventually.

@darkv darkv merged commit 6b3cba4 into wocommunity:master Jan 15, 2014
@darkv darkv deleted the frontbase_patch branch January 16, 2014 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant