WOAdaptor 64 Bit fixes #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug flags correctly passed to compiler
ishimoto
added a commit
that referenced
this pull request
Apr 20, 2014
I can't test for Windows, don't know what that is, BUT I believe on markusstoll programming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were obvious errors in pointer arithmetic, that could not work when compiled for 64 Bit.
As in most cases the address space of your WebServer stays in the lower 32 Bit, no one noticed. With Windows Server 2012 however, every process seems to get its random address somewhere in the middle of your 64 Bit address space. And WebObjects.dll crashes almost ever.
This patch fixes this issue, removes a few further warnings and adds compilation definitions for compiling against Apache under Windows. And I propose a new version number.
I will supply compiled Binaries for Windows and send them to Pascal.