Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AjaxFlexibleFileUpload serializable #654

Merged

Conversation

paulhoadley
Copy link
Contributor

This pull request makes AjaxFlexibleFileUpload serializable, and is a fix for #653.

Here we just make the Logger static so that the class is serializable.
@darkv
Copy link
Member

darkv commented May 21, 2015

This will change the reported class name for those using the logger and having subclassed the AjaxFlexibleFileUpload. But making that logger static makes sense to me.

@paulhoadley
Copy link
Contributor Author

Yes, what you say is true, but there's no way around it: if the field is static, we can't call getClass() in it's initialisation. I'd argue that the more important issue is that the class advertises Serializable, but, as written, it's not serializable. (Of course, I'm arguing that precisely because I want to serialize it and can't!)

What about if I advertise the change on the list and see if this would affect anyone in the way you describe?

@darkv
Copy link
Member

darkv commented May 21, 2015

Or merge this and put a note on the next release notes about that change?

@paulhoadley
Copy link
Contributor Author

I'm happy to do both. (I'd be surprised if it affected anyone at all.) I'll post now, you can merge this in 24-48 hours if there's no feedback.

@darkv
Copy link
Member

darkv commented May 21, 2015

Fine :-)

@paulhoadley
Copy link
Contributor Author

No response on the list in 36 hours...

darkv added a commit that referenced this pull request May 23, 2015
…erialization

Make AjaxFlexibleFileUpload serializable
@darkv darkv merged commit b1457e0 into wocommunity:master May 23, 2015
@paulhoadley paulhoadley deleted the fix-ajaxflexiblefileupload-serialization branch May 30, 2015 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants