Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add er.rest.format16BytesDataAsUUID property to encode 16 byte #965

Merged

Conversation

spelletier
Copy link
Member

NSData as pretty uuid string in json. This option only affect exactly 16 bytes data values.

Add er.rest.rfcDateFormat=rfc822 line in the default property file (with the existing defualt value) to make the existence of this property more visible.

…a as pretty uuid string in json.

Add er.rest.rfcDateFormat=rfc822 line in the default property file (with the existing defualt value) to make the existence of this property more visible.
@paulhoadley paulhoadley self-requested a review January 7, 2022 07:04
Copy link
Contributor

@paulhoadley paulhoadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be true by default. I don't know how many people are emitting Base64-encoded NSData via REST, but anyone who is will be pretty surprised to see their 16-byte values rendered as a UUID, won't they?

@spelletier
Copy link
Member Author

Good remark.. Thank you. Default updated to previous behaviour.

@hprange hprange merged commit 87766da into wocommunity:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants