Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXIF rotation information should be addressed #395

Open
kiyoon opened this issue Jul 9, 2024 · 7 comments
Open

EXIF rotation information should be addressed #395

kiyoon opened this issue Jul 9, 2024 · 7 comments

Comments

@kiyoon
Copy link

kiyoon commented Jul 9, 2024

Describe the bug
Some photos (especially from digital cameras) bake EXIF rotation information instead of making the aspect ratio actually vertical. Most image viewers read the information and rotate the view. It seems like Oculante doesn't do this and many of my photos are rotated.

Desktop (please complete the following information):

  • OS: macOS 14
@woelper
Copy link
Owner

woelper commented Jul 9, 2024

This is a very good point. I am using the image library for loading most formats and have hoped for a long time to have exif / rotation support from it. Here are related upstream issues:
image-rs/image#2222
image-rs/image#1045

Maybe it is worth considering to rotate the images manually when loading.

@kiyoon
Copy link
Author

kiyoon commented Jul 9, 2024

In zune-imageprocs there is an auto orient function but I'm not so sure if you can use it with image-rs.

@Shnatsel
Copy link

I'm working on Exif orientation support in image for use in wondermagick.

I should get it working in the next few days, but there's no telling how long will it take to get the changes reviewed and released as part of image. You might have to just copy-paste some code if you need it ASAP.

@Shnatsel
Copy link

I got it working in wondermagick, but my implementation relies on several PRs not yet merged into image:
image-rs/image#2291
image-rs/image#2292

@woelper
Copy link
Owner

woelper commented Jul 28, 2024

Wow! Firstly, wondermagick looks amazing!

Super cool you are adding this to image. Maybe all I have to do is wait then? Do you have experience with the time needed in image to merge PRs like yours? If that is a long time away, I might copy and paste some of your solution first.

Cheers!

@Shnatsel
Copy link

My PRs for Exif support have been merged into image git:
image-rs/image#2299
image-rs/image#2319
image-rs/image#2291

You can now make use of them provided you're OK with depending on a git version of image crate.

@woelper
Copy link
Owner

woelper commented Sep 13, 2024

That is amazing news, thanks!

If I recall correctly I am using some other crates that need to match the image crate I am using, so this might be difficult. Also I think I can't publish on crates.io with git dependencies unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants