Expose in place operations on DynamicImage

[Shnatsel]

This is a straightforward pass-through of the existing imageops functions.

[ripytide]

I thought we were removing the image ops functionality to the imageproc crate, propagating the imageops methods seems to be in conflict with this goal #2238 as they would eventually be deprecated and removed

[Shnatsel]

Rotations and flips are required to apply JPEG orientation metadata. We will want reading JPEGs with the correct orientation to "just work" in the future without extra dependencies, so rotations and flips specifically have to stay.

I agree with removing blur, huerotate, etc.

[ripytide]

But is that not the responsibility of the decoding jpeg library and not something we should expose as a public method on the image types in this crate? Especially since none of the rotation or flipping functions are used anywhere within the crate as far as I can see.

[Shnatsel]

Exif metadata can also appear on PNG and WebP images. And none of the format decoders actually parse Exif themselves. So it is preferable to implement it once on top of the different decoders, instead of trying to plumb it into each low-level format decoder.

[ripytide]

Would you be able to use the flip/rotate functions from the imageproc library when they eventually get released?

[kornelski]

These days EXIF rotation is de-facto required for decoding of JPEG images the way users expect.

For historical reasons it's a bit overcomplicated, but it can be considered a part of the codec now.

[fintelia]

I commented here but I'd actually rather only expose a single rotate-in-place method. The DynamicImage type already has so many methods that each additional one we add makes it that much harder for users to find the functionality they're looking for

[Shnatsel]

Understood. I'll change the newly added methods to private and add a single function for in-place rotation in #2299. Closing in favor of #2299.