Rework README file #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojpawlik
reviewed
Sep 9, 2021
README.md
Outdated
| { | ||
| // yada yada ... | ||
| "scripts": { | ||
| "build": "deno2node <tsConfigFilePath>" |
There was a problem hiding this comment.
Nitpick: I usually use prepare, because npm invokes it installing from GitHub. yarn invokes prepack.
There was a problem hiding this comment.
prepare has several use cases, as it is also invoked automatically. Users who know this are able to adjust the example, others will appreciate a descriptive name.
That being said, it's obviously your choice 😉
wojpawlik
requested changes
Dec 4, 2021
wojpawlik
force-pushed
the
rework-reamde
branch
from
d7d8886 to
5c41be8
Compare
wojpawlik
approved these changes
Dec 4, 2021
wojpawlik
reviewed
Dec 4, 2021
Co-authored-by: Wojciech Pawlik <woj.pawlik@gmail.com>
KnorpelSenf
commented
Dec 4, 2021
wojpawlik
reviewed
Dec 4, 2021
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These docs are good enough to be merged as-is IMO, but feel free to change anything as you wish. This README can just as well serve as a starting point.