Explicitly initialize an EventBus instance #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
approved these changes
Jun 11, 2020
|
Can you check "Allow edits from maintainers" please? |
|
@wojtekmaj Trying to figure out how to do that - the checkbox that is supposed to be in the sidebar is not there - have no idea what's going on with that. Should I add you as a collaborator? Or close this one and try a new PR and see if it shows up if I try again? |
|
Turns out forking it under the Sprokets org prevents that checkbox from being enabled: https://github.saobby.my.eu.orgmunity/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847 I added you with write access to the repo - if that isn't sufficient I can re-fork it on my personal account and create a new PR. |
|
Hmmm, that didn't do it - I raised another PR with your changes, no need to worry :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work taken directly from #550 by @kylemellander
Included in pdf.js v2.4.456 was a deprecation for
getGlobalEventBuswhich was being implicitly used behind the scenes. They now suggest the following:More info on that here: Deprecate
getGlobalEventBusand update the "viewer components" examples accordingly