[breaking] Refactor TextLayer to use pdfjs.renderTextLayer #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
force-pushed
the
render-text-layer
branch
from
06c6f6f to
be37187
Compare
This was referenced Mar 19, 2022
Closed
This was referenced Apr 5, 2022
wojtekmaj
force-pushed
the
render-text-layer
branch
2 times, most recently
from
f2c6d67 to
bb3f6f4
Compare
|
Hey, just wondering when will this be merged with the main branch? |
+1 |
wojtekmaj
force-pushed
the
render-text-layer
branch
from
bb3f6f4 to
d72391d
Compare
- Text layer alignment significantly improved - New prop: enhanceTextSelection - New prop: onRenderTextLayerError - New prop: onRenderTextLayerSuccess Breaking changes: - onGetTextSuccess is now called with an object containing items and styles - TextLayer.css must be imported for TextLayer to work properly
wojtekmaj
force-pushed
the
render-text-layer
branch
from
d72391d to
2187fcd
Compare
wojtekmaj
added a commit
that referenced
this pull request
Apr 20, 2022
- Text layer alignment significantly improved - New prop: enhanceTextSelection - New prop: onRenderTextLayerError - New prop: onRenderTextLayerSuccess Breaking changes: - onGetTextSuccess is now called with an object containing items and styles - TextLayer.css must be imported for TextLayer to work properly
wojtekmaj
added a commit
that referenced
this pull request
Apr 20, 2022
- Text layer alignment significantly improved - New prop: enhanceTextSelection - New prop: onRenderTextLayerError - New prop: onRenderTextLayerSuccess Breaking changes: - onGetTextSuccess is now called with an object containing items and styles - TextLayer.css must be imported for TextLayer to work properly
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhanceTextSelectiononRenderTextLayerErroronRenderTextLayerSuccessBreaking changes:
onGetTextSuccessis now called with an object containing items and stylesTextLayer.cssmust be imported for TextLayer to work properlyCloses #477
Closes #513
Closes #599
Closes #650
Closes #903
Closes #976