Fix crash after make-event-props update

wojtekmaj · Oct 9, 2021 · 960c05c · 960c05c
1 parent 5371ef0
commit 960c05c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/sample/yarn.lock b/sample/yarn.lock
@@ -3849,9 +3849,9 @@ fsevents@~2.3.2:
   linkType: hard
 
 "make-event-props@npm:^1.1.0":
-  version: 1.2.0
-  resolution: "make-event-props@npm:1.2.0"
-  checksum: 3fe45b1d01ddda97b3a9621f7475fb8dbad6e4d4336b8bed2d7a05f89592f6f86e3dc1cefa1b0ccaad38e4315fb57fbb31b3b44a5349ab63d777ea06d4fc65b6
+  version: 1.3.0
+  resolution: "make-event-props@npm:1.3.0"
+  checksum: 92b8845f63a25fc7da80ed2a5cc5055fba30066b83ad88e4f8c090cd99ae53a13297156df0bd0487d340507994362deaed5580266f73dfe142dc46163b5b8a6a
   languageName: node
   linkType: hard
 

diff --git a/src/TimePicker.jsx b/src/TimePicker.jsx
@@ -254,9 +254,12 @@ export default class TimePicker extends PureComponent {
   }
 
   render() {
+    const { eventProps } = this;
     const { className, disabled } = this.props;
     const { isOpen } = this.state;
 
+    const { onChange, ...eventPropsWithoutOnChange } = eventProps;
+
     return (
       <div
         className={mergeClassNames(
@@ -265,7 +268,7 @@ export default class TimePicker extends PureComponent {
           `${baseClassName}--${disabled ? 'disabled' : 'enabled'}`,
           className,
         )}
-        {...this.eventProps}
+        {...eventPropsWithoutOnChange}
         onFocus={this.onFocus}
         ref={(ref) => {
           if (!ref) {

diff --git a/test/yarn.lock b/test/yarn.lock
@@ -4431,9 +4431,9 @@ fsevents@~2.3.2:
   linkType: hard
 
 "make-event-props@npm:^1.1.0":
-  version: 1.2.0
-  resolution: "make-event-props@npm:1.2.0"
-  checksum: 3fe45b1d01ddda97b3a9621f7475fb8dbad6e4d4336b8bed2d7a05f89592f6f86e3dc1cefa1b0ccaad38e4315fb57fbb31b3b44a5349ab63d777ea06d4fc65b6
+  version: 1.3.0
+  resolution: "make-event-props@npm:1.3.0"
+  checksum: 92b8845f63a25fc7da80ed2a5cc5055fba30066b83ad88e4f8c090cd99ae53a13297156df0bd0487d340507994362deaed5580266f73dfe142dc46163b5b8a6a
   languageName: node
   linkType: hard
 

diff --git a/yarn.lock b/yarn.lock
@@ -5078,9 +5078,9 @@ __metadata:
   linkType: hard
 
 "make-event-props@npm:^1.1.0":
-  version: 1.2.0
-  resolution: "make-event-props@npm:1.2.0"
-  checksum: 3fe45b1d01ddda97b3a9621f7475fb8dbad6e4d4336b8bed2d7a05f89592f6f86e3dc1cefa1b0ccaad38e4315fb57fbb31b3b44a5349ab63d777ea06d4fc65b6
+  version: 1.3.0
+  resolution: "make-event-props@npm:1.3.0"
+  checksum: 92b8845f63a25fc7da80ed2a5cc5055fba30066b83ad88e4f8c090cd99ae53a13297156df0bd0487d340507994362deaed5580266f73dfe142dc46163b5b8a6a
   languageName: node
   linkType: hard