Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splash screen not aligned vertically #3

Closed
tzapu opened this issue Dec 15, 2016 · 6 comments
Closed

splash screen not aligned vertically #3

tzapu opened this issue Dec 15, 2016 · 6 comments

Comments

@tzapu
Copy link
Contributor

tzapu commented Dec 15, 2016

it appears somewhere in the first third of the screen for me

@wojtkowiak
Copy link
Owner

Is your splash screen image without any unnecessary margins?
It is weird because the windows itself is positioned by passing center: true to Chrome and it should always work. The image itself has 'background-position': 'center center', so it also should be bulletproof.
Are you using a different configuration than

        "meteor-desktop-splash-screen": {
            "version": "0.0.31",
            "windowSettings": {
                "width": 800,
                "height": 600
            }
        },

?

@tzapu
Copy link
Contributor Author

tzapu commented Dec 16, 2016

hi, so:

  • splash screen png size: 800x600 (so it looks nice on retina displays)
  • no margins on image
  • splash screen settings
    "meteor-desktop-splash-screen": {
            "version": "0.0.31",
            "windowSettings": {
                "width": 400,
                "height": 300
            }
     },

maybe the fact that it's double the resolution moves it up?

@wojtkowiak
Copy link
Owner

I would bet on that. I did not have time yet to test this.
In the meantime if you really want to leave the window settings to this size you can play with:
http://www.w3schools.com/cssref/css3_pr_background-size.asp

You can override the default css in plugin settings: https://github.com/wojtkowiak/meteor-desktop-splash-screen#settings

The default style set is here: https://github.com/wojtkowiak/meteor-desktop-splash-screen/blob/master/src/htmlBody.js#L34

@tzapu
Copy link
Contributor Author

tzapu commented Dec 17, 2016

ah, cool, will play with it then mon/tue and get back

thanks

tzapu added a commit to tzapu/meteor-desktop-splash-screen that referenced this issue Dec 19, 2016
tzapu added a commit to tzapu/meteor-desktop-splash-screen that referenced this issue Dec 20, 2016
@wojtkowiak wojtkowiak reopened this Dec 20, 2016
@wojtkowiak
Copy link
Owner

released 0.1.0

@tzapu
Copy link
Contributor Author

tzapu commented Dec 21, 2016

works perfectly for me on macOS now. thanks.

@tzapu tzapu closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants