-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-5: Added support for Electron 5 #227
Conversation
@wojtkowiak will you get a chance to take a look at this in the near future (now Electron 5 has been released)? |
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 58.63% 58.27% -0.36%
==========================================
Files 20 20
Lines 1494 1498 +4
==========================================
- Hits 876 873 -3
- Misses 618 625 +7
Continue to review full report at Codecov.
|
Is there any update on this (maybe offline conversations?) @KoenLav ? |
@dorian-coygo no updates. Pinging @wojtkowiak |
Hey, sorry for a half a year of silence. I will try to resume working on meteor-desktop within a week. |
@wojtkowiak have you seen this initiative: https://github.com/Meteor-Community-Packages Maybe it's a good idea to create a bit more documentation on how to release meteor-desktop as a package on NPM and works towards transferring it over to the Meteor Community Packages organization at some point? Thanks for all your hard work either way! |
Also happy to use GitHub sponsors. If you decide to move away from the package, thank you so much for all your hard work! |
electron-5: Added support for Electron 5
Allow config header Access-Control-Allow-Origin on LocalServer module
Fix mas build
Electron 5 no longer supports protocol.registerStandardSchemes; it was replaced by protocol.registerSchemesAsPrivileged.