Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-5: Added support for Electron 5 #227

Merged
merged 28 commits into from
Nov 28, 2019
Merged

electron-5: Added support for Electron 5 #227

merged 28 commits into from
Nov 28, 2019

Conversation

KoenLav
Copy link
Contributor

@KoenLav KoenLav commented Mar 4, 2019

Electron 5 no longer supports protocol.registerStandardSchemes; it was replaced by protocol.registerSchemesAsPrivileged.

@KoenLav
Copy link
Contributor Author

KoenLav commented Apr 24, 2019

@wojtkowiak will you get a chance to take a look at this in the near future (now Electron 5 has been released)?

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #227 into master will decrease coverage by 0.35%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   58.63%   58.27%   -0.36%     
==========================================
  Files          20       20              
  Lines        1494     1498       +4     
==========================================
- Hits          876      873       -3     
- Misses        618      625       +7
Impacted Files Coverage Δ
skeleton/app.js 5.32% <0%> (-0.43%) ⬇️
skeleton/modules/localServer.js 82.74% <50%> (-0.34%) ⬇️
...eleton/modules/autoupdate/assetBundleDownloader.js 89.9% <0%> (-2.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4f21b...b84fa88. Read the comment docs.

@dorian-coygo
Copy link

Is there any update on this (maybe offline conversations?) @KoenLav ?

@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 17, 2019

@dorian-coygo no updates.

Pinging @wojtkowiak

@wojtkowiak
Copy link
Owner

Hey, sorry for a half a year of silence. I will try to resume working on meteor-desktop within a week.
It's been a crazy time for me and I am no longer working on a meteor project but I still intend to take care of this package.

@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 17, 2019

@wojtkowiak have you seen this initiative: https://github.com/Meteor-Community-Packages

Maybe it's a good idea to create a bit more documentation on how to release meteor-desktop as a package on NPM and works towards transferring it over to the Meteor Community Packages organization at some point?

Thanks for all your hard work either way!

@dorian-coygo
Copy link

Also happy to use GitHub sponsors. If you decide to move away from the package, thank you so much for all your hard work!

@wojtkowiak wojtkowiak merged commit 5aea4cc into wojtkowiak:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants