Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

This PR adds a GitHub Actions workflow to test compilation using g++ and clang compilers.

  • Tests compilation with gcc versions 9-12
  • Tests compilation with clang versions 10-14
  • Uses ubuntu-latest for all jobs
  • Follows same pattern as wolfSSL's multi-compiler.yml

Link to Devin run: https://app.devin.ai/sessions/ba369f2814354098a9ad07160875a337
Requested by: andrew@wolfssl.com

Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

devin-ai-integration bot and others added 4 commits February 18, 2025 07:03
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
@LinuxJedi
Copy link
Member

This will need a squash when merging, but I think it covers what I asked for.

Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great in that it adds testing with different compilers. I think it misses what the pull request title suggests though, and does not test with something along the lines of ./configure --enable-all CC=g++. Forcing the use of g++ when compiling wolfSSH.

devin-ai-integration bot and others added 17 commits February 21, 2025 18:09
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
Co-Authored-By: andrew@wolfssl.com <andrew@wolfssl.com>
@LinuxJedi
Copy link
Member

Closing this. Devin misunderstood the review comment as being too specific, spiralled and it is going to be a do-over judging by the current state of the test.

@LinuxJedi LinuxJedi closed this Feb 24, 2025
@ejohnstown ejohnstown deleted the devin/1739861998-add-compiler-matrix branch June 12, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants