Support in SSL for setting a private key id#2078
Merged
toddouska merged 3 commits intowolfSSL:masterfrom Feb 12, 2019
Merged
Conversation
Works with PKCS wolfSSL#11 to use key on device.
SparkiDev
force-pushed
the
ssl_priv_id
branch
from
1a64c62 to
e86aae0
Compare
toddouska
reviewed
Feb 11, 2019
wolfcrypt/src/wc_pkcs11.c
Outdated
| rv = session->func->C_FindObjects(session->handle, key, 1, &count); | ||
| if (rv != CKR_OK) | ||
| ret = WC_HW_E; | ||
| session->func->C_FindObjectsFinal(session->handle); |
Contributor
Author
There was a problem hiding this comment.
Yes.
Changed all calls to C_FindObjectsFinal to check for an error.
toddouska
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works with PKCS #11 to use key on device.