Add support to PKCS #11 for AES-CBC and NO_PKCS11 defines#2102
Merged
toddouska merged 2 commits intowolfSSL:masterfrom Feb 22, 2019
Merged
Add support to PKCS #11 for AES-CBC and NO_PKCS11 defines#2102toddouska merged 2 commits intowolfSSL:masterfrom
toddouska merged 2 commits intowolfSSL:masterfrom
Conversation
Added PKCS wolfSSL#11 specific defines to turn off support for algorithms.
SparkiDev
force-pushed
the
pkcs11_aes_cbc
branch
from
5d4a6d1 to
520ae52
Compare
toddouska
reviewed
Feb 20, 2019
wolfcrypt/src/wc_pkcs11.c
Outdated
| aes->idLen); | ||
| } | ||
| if (ret == 0 && clear) { | ||
| XMEMSET(aes->devKey, 0, aes->keylen); |
Contributor
There was a problem hiding this comment.
Should we be using ForceZero here instead?
Contributor
There was a problem hiding this comment.
The aes.c wc_AesFree does a ForceZero on devKey...
https://github.com/wolfSSL/wolfssl/blob/master/wolfcrypt/src/aes.c#L6598
Don't memset the key field of AES in PKCS#11.
toddouska
approved these changes
Feb 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PKCS #11 specific defines to turn off support for algorithms.