PKCS #11 support for HMAC with MD5, SHA, SHA-2 #2103
Merged
dgarske merged 4 commits intowolfSSL:masterfrom Feb 28, 2019
Merged
Conversation
SparkiDev
force-pushed
the
pkcs11_hmac
branch
2 times, most recently
from
b57ff51 to
e4a0091
Compare
SparkiDev
changed the title
SparkiDev
force-pushed
the
pkcs11_hmac
branch
2 times, most recently
from
84e1b48 to
4ebff05
Compare
toddouska
reviewed
Feb 25, 2019
src/internal.c
Outdated
Contributor
There was a problem hiding this comment.
ret is zero from AllocKey above, now we're ignoring RSA or ECC keys if they weren't build in but we are succeeding on return code? That doesn't make sense to me.
Contributor
Author
There was a problem hiding this comment.
I assumed that keyType couldn't be set to rsa_sa_algo unless !NO_RSA.
Changed to return NOT_COMPILED_IN in these cases.
SparkiDev
force-pushed
the
pkcs11_hmac
branch
from
0c91a55 to
a2f8747
Compare
dgarske
approved these changes
Feb 28, 2019
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Thanks Sean. I tested this PR along with the tests in https://github.com/wolfSSL/wolfssl-examples/tree/master/pkcs11 and all looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.