TLS 1.3 ClientHello rework and other fixes#2314
Merged
toddouska merged 1 commit intowolfSSL:masterfrom Jul 8, 2019
Merged
Conversation
Do version negotiation first. Look for, parse and negotiate with SupportedVersions extension upfront. Only need to handle TLS 1.3 ClientHello after this. Any version greater than TLS 1.2 in Legacy Version field is translated to TLS 1.2. Fix preMasterSz to when not using PreSharedKey. Not finsing KeyShare in ClientHello sends a missing_extension alert. Decoding signature algorithms in new TLS 1.3 range now returns error when not recognized. Don't allow RSA PKCS #1.5 signatures to be verified. Fix accept when downgraded from TLS 1.3 to go to wolfSSL_accept. Fix server state when sending ChangeCipherSpec for MiddleBox compatability. Send a new session ticket even when resuming.
Contributor
|
retest this please |
toddouska
approved these changes
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do version negotiation first. Look for, parse and negotiate with
SupportedVersions extension upfront. Only need to handle TLS 1.3
ClientHello after this.
Any version greater than TLS 1.2 in Legacy Version field is translated
to TLS 1.2.
Fix preMasterSz to when not using PreSharedKey.
Not finsing KeyShare in ClientHello sends a missing_extension alert.
Decoding signature algorithms in new TLS 1.3 range now returns error
when not recognized.
Don't allow RSA PKCS #1.5 signatures to be verified.
Fix accept when downgraded from TLS 1.3 to go to wolfSSL_accept.
Fix server state when sending ChangeCipherSpec for MiddleBox
compatability.
Send a new session ticket even when resuming.