Espressif refactor WROOM32 ESP32#6587
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jul 10, 2023
Merged
Conversation
Contributor
Author
|
I believe the PRB master job failure is unrelated to the changes in this PR. |
Contributor
|
Retest this please |
dgarske
approved these changes
Jul 10, 2023
Contributor
dgarske
left a comment
There was a problem hiding this comment.
Very nice cleanup on the macros. The table in the PR is helpful. You should also update the ESP32 documentation as a next step.
gojimmypi
added a commit
to gojimmypi/wolfssl
that referenced
this pull request
Jul 10, 2023
This was referenced Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update is preparation to an upcoming large update to the Espressif codebase. Addressed here is only the refactor of macro names as related to the
WROOMkeyword.When first implemented, we never imagined there would be such a variety of ESP32 devices and arhcitectures. Many of the new ones have no reference at all to the
WROOMproduct line.Included is only a global file update of all wolfSSL repo files selected with this selection:
These replacements were made in this order:
WOLFSSL_ESPWROOM32SE$$KEEP__ESP32SE$$WOLFSSL_ESPWROOM32WOLFSSL_ESP32ESP32WROOM32ESP32$$KEEP__ESP32SE$$WOLFSSL_ESPWROOM32SENote that
WOLFSSL_ESPWROOM32SEnames a specific board and is retained.Any legacy use of the
WOLFSSL_ESPWROOM32is handled in thesettings.hfile.See also the changes in #6565 that will be needed for the upcoming PR.
Fixes zd# n/a
Testing
How did you test?
Confirmed wolfssl_test and benchmark examples working properly for ESP32 targets.
Confirmed Linux builds & examples apps:
Checklist
See #6234 for a roadmap of all Espressif improvements current in progress.