Merged
Conversation
dgarske
approved these changes
Aug 8, 2024
Contributor
|
Retest this please. client failed! Suite = DHE-RSA-AES128-SHA256 version = 3 |
dgarske
requested changes
Aug 9, 2024
| return 0; | ||
| } | ||
|
|
||
| #elif defined(WOLFSSL_RENESAS_TSIP) |
Contributor
There was a problem hiding this comment.
I don't want this removed. I added it back for a customer in ZD 18222. The TSIP RNG comes out of a CTR-DRBG but there is no issue using it as a seed for our DRBG. If a customer wants to use it directly then they can still define CUSTOM_RAND_GENERATE_BLOCK to override our DRBG and use wc_tsip_GenerateRandBlock directly.
comment to CUSTOM RAND GENERATE BLOCK
Contributor
Author
|
Added comment to |
dgarske
approved these changes
Aug 9, 2024
douzzer
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert 2b4acf5
Fix compile failure when no TSIP uses
Description
TSIP random generator is not true random generator, but it generates pseudo random based on AES CTR-DRBG. So, it needs to use CUSTOM_RAND_GENERATE_BLOCK.
fix build failure when no using TSIP
this fixes zd#18415(#4 item, TIME_OVERRIDES define)
zd#18415
Testing
Run RX72N example programs
Checklist