Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let script setup.sh exit 0 when job is done #8062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

syncom
Copy link

@syncom syncom commented Oct 10, 2024

Description

When the ESP-IDF setup process terminates successfully, it seems more intuitive to let the script "setup.sh" exit 0 to indicate success. It would also help avoid breakage when invoking the script in automation.

Testing

Run the following commands

source /PATH/TO/ESP-IDF/export.sh
cd wolfssl/IDE/Espressif/ESP-IDF/
./setup.sh
echo $? # Should return 0 

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

When the ESP-IDF setup process terminates successfully, it seems more
intuitive to let the script "setup.sh" `exit 0` to indicate success. It
would also help avoid breakage when invoking the script in automation.
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants