Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for setting wrong version in CSRs. #8136

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for setting wrong version in CSRs. #8136

wants to merge 3 commits into from
+25 −3

Conversation

anhu
Copy link
Member

@anhu anhu commented Oct 31, 2024 •
edited
Loading

Fixes ZD 18873

Testing

$ cd wolfssl
$ ./configure --enable-wolfclu
$ make all check
$ sudo make install
$cd ../wolfCLU
$ ./configure (all tried with CFLAG=-DNO_WOLFSSL_REQ_PRINT) 
$ make all
$ ./wolfssl -genkey rsa -size 2048 -out temp.key -outform pem  -output KEYPAIR
$ ./wolfssl req -new -days 1095 -config csr.conf -key temp.key.priv -out service.csr  -outform PEM -sha256
$ openssl req -in service.csr -text
        Version: 1 (0x0)
$ ./wolfssl req -in service.csr  -noout -text
        Version: 1 (0x0)

@anhu anhu requested a review from wolfSSL-Bot October 31, 2024 21:12
@anhu anhu self-assigned this Oct 31, 2024
@anhu anhu mentioned this pull request Oct 31, 2024
Open
@anhu anhu assigned wolfSSL-Bot and unassigned anhu Nov 6, 2024
dgarske
dgarske requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

src/x509.c
@@ -14840,6 +14842,23 @@ void wolfSSL_X509_REQ_free(WOLFSSL_X509* req)
wolfSSL_X509_free(req);
}

int wolfSSL_X509_REQ_set_version(WOLFSSL_X509 *x, long version) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Functions use brace on new line.

src/x509.c
long wolfSSL_X509_REQ_get_version(const WOLFSSL_X509 *req) {
WOLFSSL_ENTER("wolfSSL_X509_REQ_get_version");
if (req == NULL) {
return WOLFSSL_FAILURE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer return return 0; /* invalid arg */ here instead of WOLFSSL_FAILURE = 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarske dgarske dgarske requested changes

@wolfSSL-Bot wolfSSL-Bot Awaiting requested review from wolfSSL-Bot

Requested changes must be addressed to merge this pull request.

Assignees

@anhu anhu

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anhu @dgarske @wolfSSL-Bot