DTLS 1.3: Don't error out on app data before finishing handshake #8146
+235
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizlik
reviewed
Nov 4, 2024
| ssl->options.side == WOLFSSL_SERVER_END && | ||
| ssl->earlyData != no_early_data && | ||
| ssl->options.clientState == CLIENT_HELLO_COMPLETE) { | ||
| WOLFSSL_MSG("Processing EarlyData"); |
There was a problem hiding this comment.
Q: Do we check later that this is indeed early data (epoch 1) and not out-of-order app data?
There was a problem hiding this comment.
Added explicit check.
julek-wolfssl
force-pushed
the
dtls13-ooo-app-data
branch
3 times, most recently
from
5bc3915
to
26c7dc3
Compare
Check epoch for early data
julek-wolfssl
force-pushed
the
dtls13-ooo-app-data
branch
from
26c7dc3
to
c0c3e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.