esp32: Fix memory leaks and thread safety issues #8471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove global event variable to prevent use-after-free - Add NULL checks for event parameters - Add proper cleanup in error paths - Add proper event handler instance cleanup - Fix wifi_config initialization - Improve error handling and logging Co-Authored-By: jim@wolfssl.com <jim@wolfssl.com>
- Add proper parameter validation - Add consistent error propagation - Fix resource cleanup in error paths - Add proper mutex handling with portENTER/EXIT_CRITICAL - Fix parsing errors around preprocessor directives - Follow wolfSSL style guidelines Co-Authored-By: jim@wolfssl.com <jim@wolfssl.com>
- Add proper mutex validation and cleanup - Add hardware state validation - Add consistent error handling - Add owner validation in mutex unlock - Improve error messages and logging - Follow wolfSSL style guidelines Co-Authored-By: jim@wolfssl.com <jim@wolfssl.com>
- Add memory allocation tracking - Add stack overflow detection - Add proper initialization and error handling - Fix assembly code parsing errors - Improve error messages and logging - Follow wolfSSL style guidelines Co-Authored-By: jim@wolfssl.com <jim@wolfssl.com>
- Fix memory leaks in certificate bundle handling - Fix thread safety issues in SHA operations - Fix uninitialized variables in AES operations - Fix use-after-free in WiFi operations - Fix error handling in MP operations - Fix hardware mutex handling - Fix memory management - Test across ESP-IDF v4.1, 5.2, 5.4 and ESP8266 SDK v3.5 Co-Authored-By: jim@wolfssl.com <jim@wolfssl.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Can one of the admins verify this patch? |
Contributor
|
Converting to draft mode while I review the proposed changes. |
4 tasks
Contributor
Author
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32: Fix Memory Leaks and Thread Safety Issues
This PR addresses several critical issues in the ESP32-specific code:
Changes
Testing
Changes will be tested through CI across:
Link to Devin run
https://app.devin.ai/sessions/ef3261401c02492a886809cf95919cf1
Requested by
jim@wolfssl.com