Please use DEBUG_WOLFSSL not WOLFSSL_DEBUG

[gojimmypi]

Description

I've made this mistake myself on more that one occasion: WOLFSSL_DEBUG vs DEBUG_WOLFSSL.

The correct macro for wolfSSL debugging is DEBUG_WOLFSSL.

I've made some corrections that already exist in the codebase and added this to settings.h to avoid future mistakes:

#ifdef WOLFSSL_DEBUG
    #error "Please use DEBUG_WOLFSSL not WOLFSSL_DEBUG"
#endif

As for the pattern:

#ifdef DEBUG_WOLFSSL
        printf("Testing something...\n");
#endif

It is best to use WOLFSSL_MSG from wolfssl/wolfcrypt/logging.h.

WOLFSSL_MSG("Testing something...\n");

Fixes zd#

Testing

Manual testing only

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[dgarske]

Jenkins retest this please. History lost

[JacobBarthelmeh]

Some good changes where WOLFSSL_DEBUG was corrected to DEBUG_WOLFSSL. I don't think we should start error'ing though when encountering WOLFSSL_DEBUG.

[gojimmypi]

Refresh from upstream for #9061 fix, squashed commits & force-pushed to retest.

This forced logic removed per code review, consider spell check instead:

#ifdef WOLFSSL_DEBUG
    #error "Please use DEBUG_WOLFSSL not WOLFSSL_DEBUG"
#endif

[gojimmypi]

Jenkins retest this please

For AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n]was marked offline: Connection was broken