Force old OID values: WOLFSSL_OLD_OID_SUM for WC_16BIT_CPU #9075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR forces
WOLFSSL_OLD_OID_SUMinsettings.hwhenWC_16BIT_CPUis encountered.Some CPU platforms, when smaller than 32 bit, will have the compiler ignore the upper 16 bits of an enum value.
(yes, I was surprised, too)
This is problematic in the new OID values of wolfssl/wolfcrypt/oid_sum.h
For instance:
Where:
Note that
WC_16BIT_CPUis currently a manual specification, NOT auto-detected.Although
WOLFSSL_OLD_OID_SUMcould also have been manually specified to solve the problem, it is more intuitive to have it defined for a reason: whenWC_16BIT_CPUis encountered.Fixes zd# n/a
Testing
Tested with my WIP Arduino workflow tests for example this one:
See output:
Checklist