Change certs_test sizeof const to define for Watcom #9099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates gencertbuf.pl to generate
#define sizeof_...instead ofstatic const int sizeof_...For example:
Instead of
Since C89/C90 (which Watcom generally defaults to), sizeof must be a compile-time constant expression when used in a static initializer.
Otherwise Watcom will fail to compile:
Fails with this error:
Due to this initialization syntax:
Fixes zd# n/a
Testing
How did you test?
Considered some sort of GitHub workflow, but it would been to be a source-code-scanning exercise, not a Watcom-compiling check.
Manually tested with Watcom.
Also basic test with:
./gencertbuf.pl ./autogen.sh ./configure --enable-all make distclean make make testChecklist