SM2 TLS1.3: Fix certificate verify #9175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code to verify with SM2/SM3 was not able to be reached. The check of hsType (which was ECC for both ECC and SM2/SM3) was replaced with a check of peerSigAlgo for ecc_dsa_sa_algo which is different for ECDSA and SM2/SM3.
Contributor
|
I can confirm this is working for me on:
|
gojimmypi
added a commit
to gojimmypi/wolfssl
that referenced
this pull request
Sep 12, 2025
Contributor
|
Heads up I have some GitHub workflows in progress for both wolfssl and wolfsm repos to test SM Ciphers. See initial example results from sm-cipher.yml |
This was referenced Sep 12, 2025
Contributor
|
Retest this please Jenkins |
JacobBarthelmeh
approved these changes
Sep 16, 2025
Contributor
|
@SparkiDev there is an RSA PSS test suite failure. Could be a flaky test. |
Contributor
|
Jenkins retest this please For gentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n]was marked offline: Connection was broken in PRB-generic-config-parser/10361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code to verify with SM2/SM3 was not able to be reached. The check of hsType (which was ECC for both ECC and SM2/SM3) was replaced with a check of peerSigAlgo for ecc_dsa_sa_algo which is different for ECDSA and SM2/SM3.
Fixes #9169
Testing
Built with SM code installed and tests now pass.
Checklist