20251020-coverity-WC_SAFE_foo #9324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douzzer
force-pushed
the
20251020-coverity-WC_SAFE_foo
branch
from
11c008b to
e1bb492
Compare
* fix WC_MIN_SINT_OF(). * add outer cast back to target type in WC_MAX_UINT_OF() and WC_MAX_SINT_OF(). * rename WC_SAFE_SUM_*_NO_WUR to WC_SAFE_SUM_*_CLIP(). * remove clipping assignments from failure paths in WC_WUR_INT() variants. * add WC_SAFE_SUB_UNSIGNED_CLIP(), WC_SAFE_SUB_UNSIGNED(), WC_SAFE_SUB_SIGNED_CLIP(), and WC_SAFE_SUB_SIGNED(). * add Coverity-specific annotations in WC_SAFE_*() to suppress false-positive overflow warnings. wolfcrypt/test/test.c: * implement macro_test(). * fix stray uint32_t's in crypto_ecc_verify() and crypto_ecc_sign() arg lists. wolfssl/wolfcrypt/ext_xmss.h: fix stray uint32_t.
douzzer
force-pushed
the
20251020-coverity-WC_SAFE_foo
branch
from
e1bb492 to
279238c
Compare
…ialized local variable" in GrowOutputBuffer().
JacobBarthelmeh
approved these changes
Oct 21, 2025
philljj
approved these changes
Oct 21, 2025
Contributor
philljj
left a comment
philljj
left a comment
There was a problem hiding this comment.
Looks good, a macro sanity test for math was long due!
dgarske
requested changes
Oct 21, 2025
dgarske
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/types.h:WC_MIN_SINT_OF().WC_MAX_UINT_OF()andWC_MAX_SINT_OF().WC_SAFE_SUM_*_NO_WUR()toWC_SAFE_SUM_*_CLIP().WC_WUR_INT()variants.WC_SAFE_SUB_UNSIGNED_CLIP(),WC_SAFE_SUB_UNSIGNED(),WC_SAFE_SUB_SIGNED_CLIP(), andWC_SAFE_SUB_SIGNED().WC_SAFE_*()to suppress false-positive overflow warnings.wolfcrypt/test/test.c:macro_test().uint32_t's incrypto_ecc_verify()andcrypto_ecc_sign()arg lists.wolfssl/wolfcrypt/ext_xmss.h: fix strayuint32_t.tested with