CI builds are building a lot more than needed if a failed action is re-triggered

[rawlingsj]

The gradle 8 PR had an odd CI failure when it first ran 2 days ago. I re-triggered the failed CI build action job and noticed a lot of packages were being built when I was expecting only gradle as that was the only file changed in the PR.

After looking at the Determine package to test building job I could see

/usr/bin/git diff --diff-filter=D --name-only f8133987d6eac5f341386eed6d0ebec84b699697..23688b03160b3b75cfcc6989288cb10959b8aa9d
boost.yaml
cortex.yaml
ferretdb.yaml
flux-helm-controller.yaml
flux-kustomize-controller.yaml
flux-notification-controller.yaml
flux-source-controller.yaml
jaeger-agent.yaml
meilisearch.yaml
task.yaml

When the build wolfi job runs we see

2023-04-14T15:13:56.6149026Z �[36;1mfor package in mpc isl build-base openssl binutils etcd pax-utils busybox make linux-headers expat libsodium ncurses sqlite lua5.3 lua5.4 apk-tools hello-wolfi brotli cmake py3-ordered-set py3.11-setuptools py3.10-setuptools py3-packaging py3-docutils py3-pygments libedit tiff go-stage0 go-fips-1.20 openssh ruby-3.2 rust-stage0 libssh2 meson wasi-libc libcap libbsd libxau libxdmcp libxcb libx11 libxkb libxext libxrender libxrandr libxfixes libxi libxtst rarian libice libsm icu nano nodejs-16 nodejs-18 nodejs-19 libxt libpng freetype fontconfig openjdk-11 openjdk-17 maven-stage0 ttf-dejavu pcre kubectl libwebp libtbb mold envoy redis mailcap php composer docker-credential-ecr-login haproxy libunistring gettext libcap-ng util-linux glib msmtp nasm libxpm dav1d aom gd heimdal mosquitto memcached groff db openldap goreleaser nerdctl bom keyutils krb5-conf krb5 libtirpc spire-server alpine-keys pixman cairo gobject-introspection kmod libxft libxmu libxaw pango guile graphviz libsecret libtasn1 at-spi2-core libkcapi libidn2 libksba libassuan npth nettle gnutls gnupg dnssec-root dns-root-hints fstrm bind py3-botocore py3-asn1 py3-dateutil py3-hatchling py3-jmespath py3-pathspec py3-pluggy py3-rsa py3-yaml nginx aws-cli helm libaio libunwind lttng-ust gitsign vim netcat-openbsd gnutar dpkg ruby3.2-yajl-ruby gradle-stage0 gradle-8 python-3.12 doxygen terraform sbt-stage0 dhcping slsa-verifier iperf libmnl libpcap libssh fping ethtool iftop nsc json-c libmspack libmilter bird ipvsadm ldns dotnet-7 powershell clamav mercurial minio karpenter libidn mariadb-connector-c libspf2 exim ratelimit numactl zarf go-md2man lzo runc metacontroller conda google-cloud-sdk ; do�[0m
2023-04-14T15:13:56.6151488Z �[36;1m  make MELANGE="melange"
...

the gradle-8 package is in the list but I expected that to be the only thing built.

I wonder if tj-actions/changed-files is returning all yaml files that have changed from when the PR first opened?

[kaniini]

It's because the old PRs need to be rebased. We should just make it error if they aren't.