remove meson dependency on strip #2938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
approved these changes
Jun 19, 2023
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
meson-remove-strip
branch
from
9978053 to
5f9c666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2937 .
We had an infinite loop:
As suggested by @kaniini , this removes
mesonfrom depending onstrip, as meson is python and shouldn't need it.Unlike #2937, this is a buildtime change, so CI either will succeed in building it or not, so enabling auto-merge.