Skip to content

Conversation

@joshrwolf
Copy link
Member

@joshrwolf joshrwolf commented Jun 23, 2023

This consolidates the way we package components that are distributed via kubernetes/kubernetes. The idea here is for a central place to manage wolfi related things pertaining to kubernetes/kubernetes.

This means the addition of several kube* components (here), and the deprecation of our existing kubectl.yaml package in favor of this one.

While this works, it significantly changes how we package an existing thing (kubectl), so I'm leaving this as draft/RFC for now.

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • REQUIRED - The package is added to packages.txt

@amdawson
Copy link

heads up @mattmoor in case this has any impact on the kots build

@joshrwolf joshrwolf marked this pull request as ready for review June 23, 2023 19:13
@joshrwolf joshrwolf requested a review from a team as a code owner June 23, 2023 19:13
@joshrwolf joshrwolf requested review from kaniini and rawlingsj June 23, 2023 19:13
@imjasonh
Copy link
Member

Unless there are any remaining concerns I'd like to push this forward, so we can add the other supported k8s versions (1.25, 1.26). It might be worth landing this as kubernetes-1.27.yaml (with provides: kubernetes=1.27) directly so I don't have to do it later and we have less churn.

@joshrwolf joshrwolf force-pushed the kubernetes branch 4 times, most recently from a457582 to 5e6688a Compare June 27, 2023 16:33
@joshrwolf joshrwolf force-pushed the kubernetes branch 2 times, most recently from 2d90c00 to f00c06e Compare June 27, 2023 16:52
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good, just a couple questions

@imjasonh imjasonh enabled auto-merge June 29, 2023 13:32
@imjasonh imjasonh added this pull request to the merge queue Jun 29, 2023
Merged via the queue into wolfi-dev:main with commit c56ccb6 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants