Skip to content

Conversation

@ajayk
Copy link
Member

@ajayk ajayk commented Jul 5, 2023

No description provided.

@ajayk ajayk requested a review from a team as a code owner July 5, 2023 15:59
@ajayk ajayk requested review from imjasonh and jdolitsky July 5, 2023 15:59
Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect any breakages as part of the major version bump? Maybe we should test a few dependent builds too.

@ajayk
Copy link
Member Author

ajayk commented Jul 5, 2023

Do we expect any breakages as part of the major version bump? Maybe we should test a few dependent builds too.

2.1.91 was also (3.0 beta 2) https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.1.91

and there are 7 significant changes compared to 3.0 beta2 here https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/3.0.0

@ajayk
Copy link
Member Author

ajayk commented Jul 5, 2023

I ran some dependent builds for libjpeg-turbo

  • tiff
  • libwebp
  • guacamole-server

https://gist.github.com/ajayk/366377c8a40857fd4ff0c52235fe174b

@dlorenc
Copy link
Member

dlorenc commented Jul 5, 2023

Nice!

@kaniini
Copy link
Contributor

kaniini commented Jul 5, 2023

Should be fine, no ABI breaks as far as I can tell.

@kaniini kaniini added this pull request to the merge queue Jul 5, 2023
Merged via the queue into wolfi-dev:main with commit d813bb1 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants