comment grype scan results on PR, only works for PRs from … #3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…branches NOT forks Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
rawlingsj
changed the title
jdolitsky
reviewed
Jul 6, 2023
Member
jdolitsky
left a comment
jdolitsky
left a comment
There was a problem hiding this comment.
this need ack from @wolfi-dev/wolfi-build-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…branches NOT forks
I had this on a branch and just realised I'd not PR'd it before going on PTO. Since then I just saw a similar approach added by @jdolitsky 806e32b
They do the same kinda thing, this PR will additionally create a table of the scan results and comment on the PR. This is provided the PR is from a branch and not a fork due to GH secrets not being available in PRs.
@jdolitsky wdyt?