Skip to content

Conversation

@imjasonh
Copy link
Member

Go had a patch release for a security fix in net/http (#3531) so we should rebuild anything built with Go using that version of stdlib to ensure the fix is available in all the packages.

Previously, #1797

This was done with:

git grep -l -- "- go$" *.yaml | xargs wolfictl bump

...then reverting changes to go-[fips]-1.[19,20].yaml manually.

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh requested a review from a team as a code owner July 12, 2023 13:30
luhring
luhring previously approved these changes Jul 12, 2023
@imjasonh imjasonh enabled auto-merge July 12, 2023 13:44
@imjasonh
Copy link
Member Author

after 2h+ building, metacontroller failed with:

2023-07-12T15:49:55.4403598Z ℹ️  x86_64    | DEBUG= goreleaser build --single-target --rm-dist --snapshot --output /home/build/metacontroller
2023-07-12T15:49:55.4568582Z ⚠️  x86_64    |   • starting build...
2023-07-12T15:49:55.4569070Z ⚠️  x86_64    |   • loading config file                              file=.goreleaser.yaml
2023-07-12T15:49:55.4578064Z ⚠️  x86_64    |   ⨯ build failed after 0s                            error=yaml: unmarshal errors:
2023-07-12T15:49:55.4578458Z ⚠️  x86_64    |   line 31: field replacements not found in type config.Archive
2023-07-12T15:49:55.4585831Z ⚠️  x86_64    | make: *** [Makefile:22: build] Error 1
2023-07-12T15:49:55.4591071Z 2023/07/12 15:49:55 ERROR: failed to build package. the build environment has been preserved:

I'm going to remove it from this bump and try to figure out if this is a pervasive issue.

Signed-off-by: Jason Hall <jason@chainguard.dev>
luhring
luhring previously approved these changes Jul 12, 2023
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

imjasonh commented Jul 12, 2023

This time it failed on newrelic-infrastructure-agent:

2023-07-12T18:58:49.9178604Z ℹ️  x86_64    | Error (git-checkout): expect commit 29f18ead67f8279c57dbfc5ad5fde94d0bc991c5, got 4778a9187654402c775b677dcf4af28e3e3d7dad

The commit we have passed when wolfibot updated it, but it's different now: https://github.com/newrelic/infrastructure-agent/releases/tag/1.43.2

They may have updated the tag some time after wolfibot built the updated package, which would explain this. Anyway, using the new commit, let's see what happens 🤞

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

newrelic-prometheus-configurator failed with:

2023-07-13T02:12:25.9247466Z ℹ️  x86_64    | Error (git-checkout): expect commit c5391aaa333d6f4003916b7bf4fef757ffa35618, got 15fdd3d7dcfa8b1454ee70d962935425c9f3e5f0

...which looks right to me: https://github.com/newrelic/newrelic-prometheus-configurator/releases/tag/v1.4.2 🤔

Updating, let's try it again.

@imjasonh imjasonh added this pull request to the merge queue Jul 13, 2023
Merged via the queue into wolfi-dev:main with commit 4252aae Jul 13, 2023
@imjasonh imjasonh deleted the go-bump-jul-12 branch July 13, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants