Skip to content

Conversation

@wolfi-bot
Copy link
Contributor

@wolfi-bot wolfi-bot requested a review from a team as a code owner July 13, 2023 15:09
@wolfi-bot wolfi-bot requested a review from luhring July 13, 2023 15:09
@wolfi-bot wolfi-bot added the request-version-update request for a newer version of a package label Jul 13, 2023
@wolfi-bot wolfi-bot requested a review from joshrwolf July 13, 2023 15:09
@rawlingsj
Copy link
Member

@kaniini the so name check failed here but nothing else depends on conda, are we ok to override and merge?

@rawlingsj rawlingsj mentioned this pull request Jul 18, 2023
@dlorenc
Copy link
Member

dlorenc commented Jul 18, 2023

@kaniini the so name check failed here but nothing else depends on conda, are we ok to override and merge?

Oh, we might want to add a noprovides to this one to avoid screwing up the dag.

@dlorenc
Copy link
Member

dlorenc commented Jul 18, 2023

@kaniini the so name check failed here but nothing else depends on conda, are we ok to override and merge?

Oh, we might want to add a noprovides to this one to avoid screwing up the dag.

Actually, we already have that. So this is fine to override: https://github.com/wolfi-dev/os/blob/main/conda.yaml

@dlorenc
Copy link
Member

dlorenc commented Jul 19, 2023

@kaniini the so name check failed here but nothing else depends on conda, are we ok to override and merge?

Oh, we might want to add a noprovides to this one to avoid screwing up the dag.

Actually, we already have that. So this is fine to override: https://github.com/wolfi-dev/os/blob/main/conda.yaml

I'm just gonna hit merge when ready, I'm pretty sure this is safe and we should disable the ABI checker here.

@dlorenc dlorenc enabled auto-merge July 19, 2023 17:18
@dlorenc
Copy link
Member

dlorenc commented Jul 19, 2023

Whoops, we will need to override here...

@kaniini kaniini disabled auto-merge July 19, 2023 17:22
@kaniini kaniini merged commit 279b98b into main Jul 19, 2023
@kaniini kaniini deleted the wolfictl-1c19e527-33a7-4f90-8053-ef78127e97c2 branch July 19, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated pr request-version-update request for a newer version of a package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants