-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: icu 76.1 package update as contains ABI breakage, bumps dependants that have already been built with new ABI #36864
Conversation
…dants that have already been built with new ABI see wolfi-dev#35274 Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
Also likely want to withdraw 76.1 APKs |
yeah lemme push another commit to this PR |
Gen AI suggestions to solve the build error: • Detected Error: "HTTP request sent, awaiting response... 503 Service Unavailable" • Error Category: Fetch/Download • Failure Point: Pipeline fetch step attempting to download ICU source code • Root Cause Analysis: The GitHub release download URL is unavailable or incorrectly formed. This could be due to:
• Suggested Fix:
- uses: fetch
with:
uri: https://github.com/unicode-org/icu/releases/download/release-${{vars.dash-package-version}}/icu4c-${{vars.underscore-package-version}}-src.tgz to: - uses: fetch
with:
uri: https://download.icu-project.org/files/icu4c/${{package.version}}/icu4c-${{vars.underscore-package-version}}-src.tgz • Explanation:
• Additional Notes:
• References:
|
Gen AI suggestions to solve the build error: • Detected Error: ```
environment:
contents:
packages:
- python-3.12-dev # Instead of python-3-dev
# ... rest of packages • Explanation: TensorFlow 2.18.0 has explicit version support up to Python 3.12 as shown in the requirements_lock.txt files. By forcing the build to use Python 3.12 instead of 3.13, we align with TensorFlow's supported Python versions. • Additional Notes:
• References:
|
Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
Gen AI suggestions to solve the build error: • Detected Error:
• Error Category: Version/Configuration • Failure Point: Python version compatibility check during Bazel build initialization • Root Cause Analysis: • Suggested Fix:
environment:
contents:
packages:
- python-3.12-dev # Instead of python-3-dev
environment:
HERMETIC_PYTHON_VERSION: "3.12" • Explanation: • Additional Notes:
• References:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tensorflow build was complaining during Bazel build because the Python version in the hermetic environment was defaulted to the latest 3.13 while Tensworflow's Bazel workspace doesn't support a requirements_lock.txt for 3.13. |
Gen AI suggestions to solve the build error: • Detected Error:
• Error Category: Configuration/Version • Failure Point: Python version configuration during Bazel build setup • Root Cause Analysis: The build is trying to use Python 3.13, but TensorFlow 2.18.0 only supports up to Python 3.12 as indicated by the available requirements_lock.txt files. • Suggested Fix:
environment:
HERMETIC_PYTHON_VERSION: "3.12"
data:
- name: py-versions
items:
3.10: "310"
3.11: "311"
3.12: "312" • Explanation: TensorFlow 2.18.0 hasn't been tested or configured for Python 3.13 yet. By explicitly setting HERMETIC_PYTHON_VERSION to 3.12 and limiting the build to supported Python versions, we ensure compatibility with the available requirements lock files. • Additional Notes:
• References:
|
…ment to 3.12 Signed-off-by: Massimiliano Giovagnoli <massimiliano.giovagnoli@chainguard.dev>
ef45d91
to
a846df6
Compare
The builds are good; i cannot tell if they are out of order or not; we may need to bump/rebuild a few more things; but I would rather land this sooner than later. As a lot more things are currently broken; or can get more broken as things are landing. |
see #35274
package update check is expected to fail as we are rolling back an update.