Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana-mimir/2.15.0 package update #38686

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 3, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Jan 3, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 3, 2025

Gen AI suggestions to solve the build error:

Let me help analyze and fix the build error for the Grafana Mimir package.

• Detected Error: The build appears to fail during the go/build step with a static linking error (implicit from the attempt to use static linking with glibc)

• Error Category: Build Configuration

• Failure Point: The go/build step with static linking attempt

• Root Cause Analysis: The issue stems from trying to statically link a Go binary with glibc, which is not fully supported. The -static flag in ldflags is causing the build to fail because Wolfi uses glibc rather than musl.

• Suggested Fix:

  - uses: go/build
    with:
      modroot: .
      packages: ./cmd/mimir
      output: grafana-mimir
      ldflags: "-s -w"  # Remove -extldflags -static

• Explanation:

  • Static linking with glibc is problematic and not fully supported
  • Removing the static linking flag will allow the binary to build properly with dynamic linking
  • The -s -w flags are retained to strip debugging information and reduce binary size
  • This approach is more appropriate for Wolfi's glibc-based environment

• Additional Notes:

  • Static linking is often used in Alpine/musl environments but isn't necessary or recommended in Wolfi
  • Dynamic linking is the preferred approach for glibc-based systems
  • The resulting binary will still be functional but will depend on system libraries (which is normal for glibc systems)

• References:

@Dentrax Dentrax self-assigned this Jan 4, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 4, 2025
grafana-mimir.yaml Outdated Show resolved Hide resolved
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax Dentrax force-pushed the wolfictl-2e188474-5422-4575-8691-e2c4a5e0359c branch from d45e968 to e5f193d Compare January 4, 2025 09:28
@Dentrax Dentrax enabled auto-merge (squash) January 4, 2025 09:32
@Dentrax Dentrax merged commit 4af7ada into main Jan 4, 2025
14 checks passed
@Dentrax Dentrax deleted the wolfictl-2e188474-5422-4575-8691-e2c4a5e0359c branch January 4, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants