Skip to content

Conversation

@maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Feb 7, 2025

Samba needs to be rebuilt from the rebuilt py3-event version [1] to solve build-time and runtime issues.

Furhtermore a new test for samba-client has been added with this commit.

The current published py3-tevent content differs from the one generated from current builds. With the published version samba fails to build with the error:

2025/02/07 11:01:33 ERRO failed to build package: unable to build guest: unable to generate image: installing apk packages: installing packages: installing py3-tevent (ver:0.16.2-r0 arch:x86_64): unable to install files for pkg py3-tevent: unable to install file over existing one, different contents:
usr/lib/python3.13/site-packages/talloc.cpython-313-x86_64-linux-gnu.so

Also, at runtime samba-client panics with:

$ apk add --no-cache samba-client >/dev/null && smbclient -L 127.0.0.1

Can't load /etc/samba/smb.conf - run testparm to debug it Bad talloc magic value - unknown value
=============================================================== INTERNAL ERROR: Bad talloc magic value - unknown value in smbclient () () pid 1 (4.21.3)
If you are running a recent Samba version, and if you think this problem is not yet fixed in the latest versions, please consider reporting this bug, see https://wiki.samba.org/index.php/Bug_Reporting =============================================================== PANIC (pid 1): Bad talloc magic value - unknown value in 4.21.3 BACKTRACE: 14 stack frames:
 #0 /usr/lib/samba/libgenrand-private-samba.so(log_stack_trace+0x44)
[0x7fe75f5bf814]
 #1 /usr/lib/samba/libgenrand-private-samba.so(smb_panic+0x15)
[0x7fe75f5bfab5]
 #2 /usr/lib/libtalloc.so.2(+0x5a08) [0x7fe75f5a3a08]
 #3 /usr/lib/libtalloc.so.2(talloc_named_const+0x30) [0x7fe75f5a4260]
 #4 /usr/lib/samba/libgse-private-samba.so(resolve_name_list+0x6b)
[0x7fe75eb5b38b]
 #5 /usr/lib/samba/liblibsmb-private-samba.so(+0x1805e) [0x7fe75f9fd05e]
 #6 /usr/lib/samba/liblibsmb-private-samba.so(cli_connect_nb+0x7c)
[0x7fe75fa00f5c]
 #7 /usr/lib/samba/liblibsmb-private-samba.so(+0x396f4) [0x7fe75fa1e6f4]
 #8 /usr/lib/samba/liblibsmb-private-samba.so(+0x39d67) [0x7fe75fa1ed67]
 #9 /usr/lib/samba/liblibsmb-private-samba.so(cli_cm_open+0xa7)
[0x7fe75fa1ef17]
 #10 smbclient(main+0xb9d) [0x5572699730dd]
 #11 /lib/libc.so.6(+0x26188) [0x7fe75f300188]
 #12 /lib/libc.so.6(__libc_start_main+0x8b) [0x7fe75f30024b]
 #13 smbclient(_start+0x25) [0x557269973d65]
Can not dump core: corepath not set up
  1. chore(tevent): bump epoch to rebuild #41586

@maxgio92
Copy link
Member Author

maxgio92 commented Feb 7, 2025

It depends on #41586

@octo-sts
Copy link
Contributor

octo-sts bot commented Feb 7, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the build log provided, the build appears to be interrupted/incomplete. Let me analyze what we can see and provide guidance.

• Detected Error: Build log ends abruptly during dependency installation
• Error Category: Dependency
• Failure Point: Package installation phase
• Root Cause Analysis: The build environment is being set up and installing dependencies, but appears to terminate unexpectedly during this process

• Suggested Fix:

  1. Add missing core build dependencies to the environment.packages section:
environment:
  contents:
    packages:
      # Add these dependencies
      - gcc
      - glibc-dev
      - libtool
      - gettext-dev
      # Existing packages...
  1. Consider adding explicit phase dependencies:
pipeline:
  - uses: fetch
    with:
      expected-sha256: ae2179a613e7a5d4088735ab100d4ca1cae0f92374d6307e22eaec13ad90125c
      uri: https://download.samba.org/pub/samba/stable/samba-${{package.version}}.tar.gz
    dependencies:
      - build-base

• Explanation:

  • The log shows the build environment setting up core system packages but stops during this process
  • Samba requires specific build tools that may be missing from the initial environment
  • Adding explicit gcc and development packages ensures all required build tools are available
  • Adding phase dependencies ensures proper build order

• Additional Notes:

  • Build seems to be failing early in the environment setup phase
  • Consider running with --debug flag for more verbose output
  • May need to increase any resource limits if environment setup is being killed

• References:

This appears to be an environment setup issue rather than a package-specific build failure. The suggested additions should help complete the environment initialization successfully.

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 7, 2025
Copy link
Member

@8none1 8none1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test

@maxgio92 maxgio92 marked this pull request as ready for review February 7, 2025 13:05
Samba needs to be rebuilt from the rebuilt py3-event version to solve
build-time and runtime issues.

Furhtermore a new test for samba-client has been added with this commit.

The current published py3-tevent content differs from the
one generated from current builds. With the published version
samba fails to build with the error:
2025/02/07 11:01:33 ERRO failed to build package: unable to build guest:
unable to generate image: installing apk packages: installing packages:
installing py3-tevent (ver:0.16.2-r0 arch:x86_64): unable to install
files for pkg py3-tevent: unable to install file over existing one,
different contents:
usr/lib/python3.13/site-packages/talloc.cpython-313-x86_64-linux-gnu.so

Also, at runtime samba-client panics with:
$ apk add --no-cache samba-client >/dev/null && smbclient -L 127.0.0.1

Can't load /etc/samba/smb.conf - run testparm to debug it
Bad talloc magic value - unknown value
===============================================================
INTERNAL ERROR: Bad talloc magic value - unknown value in smbclient ()
() pid 1 (4.21.3)
If you are running a recent Samba version, and if you think this problem
is not yet fixed in the latest versions, please consider reporting this
bug, see https://wiki.samba.org/index.php/Bug_Reporting
===============================================================
PANIC (pid 1): Bad talloc magic value - unknown value in 4.21.3
BACKTRACE: 14 stack frames:
 #0 /usr/lib/samba/libgenrand-private-samba.so(log_stack_trace+0x44)
[0x7fe75f5bf814]
 wolfi-dev#1 /usr/lib/samba/libgenrand-private-samba.so(smb_panic+0x15)
[0x7fe75f5bfab5]
 wolfi-dev#2 /usr/lib/libtalloc.so.2(+0x5a08) [0x7fe75f5a3a08]
 wolfi-dev#3 /usr/lib/libtalloc.so.2(talloc_named_const+0x30) [0x7fe75f5a4260]
 wolfi-dev#4 /usr/lib/samba/libgse-private-samba.so(resolve_name_list+0x6b)
[0x7fe75eb5b38b]
 wolfi-dev#5 /usr/lib/samba/liblibsmb-private-samba.so(+0x1805e) [0x7fe75f9fd05e]
 wolfi-dev#6 /usr/lib/samba/liblibsmb-private-samba.so(cli_connect_nb+0x7c)
[0x7fe75fa00f5c]
 wolfi-dev#7 /usr/lib/samba/liblibsmb-private-samba.so(+0x396f4) [0x7fe75fa1e6f4]
 wolfi-dev#8 /usr/lib/samba/liblibsmb-private-samba.so(+0x39d67) [0x7fe75fa1ed67]
 wolfi-dev#9 /usr/lib/samba/liblibsmb-private-samba.so(cli_cm_open+0xa7)
[0x7fe75fa1ef17]
 wolfi-dev#10 smbclient(main+0xb9d) [0x5572699730dd]
 wolfi-dev#11 /lib/libc.so.6(+0x26188) [0x7fe75f300188]
 wolfi-dev#12 /lib/libc.so.6(__libc_start_main+0x8b) [0x7fe75f30024b]
 wolfi-dev#13 smbclient(_start+0x25) [0x557269973d65]
Can not dump core: corepath not set up

Signed-off-by: Massimiliano Giovagnoli <massimiliano.giovagnoli@chainguard.dev>
@maxgio92 maxgio92 force-pushed the samba-rebuild-add-tests branch from 9b312dc to 9ccd005 Compare February 7, 2025 13:15
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 7, 2025
@maxgio92 maxgio92 merged commit 49c1509 into wolfi-dev:main Feb 7, 2025
14 of 15 checks passed
@maxgio92 maxgio92 deleted the samba-rebuild-add-tests branch February 7, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants