Improve Trino package #51354
Improve Trino package #51354
Conversation
ajayk
added
the
approved-to-run
kranurag7
left a comment
kranurag7
left a comment
There was a problem hiding this comment.
thank you for updating it. this is awesome.
we need to bump the epoch field here package.epoch to ensure that we get a new revision out here.
|
Thank you @kranurag7 and @ajayk - I addressed the comments now, maybe good to go... |
|
Thanks for the spelling fix @kranurag7 .. should I squash and rebase or something and is there something else I should do? |
|
@kranurag7 I upgraded to Trino 475 now as well since there are memory issues with 474 - anything else I can do to get this PR merged? |
🔄 Build Failed: Git Checkout Error
Build Details
Root Cause Analysis 🔍The build failed because the tag '475' in the Git repository is not pointing to the expected commit. The system expected commit '2d747e0e722d5127b5c25706194944bcb7a7a2f1' but found 'fd2b81e86ba1c288684746d0842c0ffc3a709598' instead. Additionally, there's a warning that 'refs/tags/475 c49a40234a7a09bcdd88451700373700100c005a is not a commit!' which suggests the tag may be pointing to a non-commit object (like a tag object) rather than directly to a commit. Was this comment helpful? Please use 👍 or 👎 reactions on this comment. |
- Upgrade to 475 since 474 has memory issues - Update to Java 24 like upstream - Remove invalid connector plugin references - Remove invalid Python requirement
|
Updated commit hash now .. 🤞 this turns green now |
|
Awesome .. thank you @ajayk |
3 participants
Trino package update. Trino 474 uses Java 24 in the container so our package should do so as well.
Also removed the need for python since the Trino launcher has been using a Go-based binary for a while and Python is no longer needed.
Also remove the Kudu and Phoenix connector plugin comment lines since we remove the connectors in upstream.
Fyi .. I am a Trino maintainer but not a wolfi expert.. ping me on Chainguard or Trino slack for discussion or comment in review.