-
Notifications
You must be signed in to change notification settings - Fork 416
cert-manager-cmctl/2.2.0-r1: cve remediation #58634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cert-manager-cmctl/2.2.0-r1: cve remediation #58634
Conversation
<!--ci-cve-scan:must-fix: GHSA-557j-xg8c-q2mm-->
📦 Build Failed: Missing Dependency
Build Details
Root Cause Analysis 🔍The build is trying to update the Go module dependency 'oras.land/oras-go' to version v1.2.6, but this package isn't listed in the go.mod file. The gobump tool requires that packages being updated must already exist in the go.mod file, or be explicitly listed in the 'replaces' parameter. 🔍 Build failure fix suggestionsFound similar build failures that have been fixed in the past and analyzed them to suggest a fix: Similar PRs with fixes
Suggested ChangesFile: cert-manager-cmctl.yaml
Replacement: Click to expand fix analysisAnalysisLooking at the three similar fixed build failures, I observe a consistent pattern: in each case, the go/bump step was trying to update a package that wasn't present in the go.mod file. The fixes generally took one of two approaches:
In Fix #0 and Fix #1, unnecessary packages were removed from the deps list. In Fix #0, one of the packages was also moved to the replaces parameter. In Fix #2, the solution was to keep the package but explicitly add it to the replaces parameter. For our current failure with "oras.land/oras-go", the error is identical in nature - we're trying to update a package that doesn't exist in the go.mod file. Click to expand fix explanationExplanationThe build failure occurs because the gobump tool is trying to update "oras.land/oras-go" to version v1.2.6, but this package is not listed in the go.mod file of the project. This is a limitation of the gobump tool which requires packages being updated to either:
By moving "oras.land/oras-go@v1.2.6" from the deps list to the replaces parameter, we're telling the gobump tool to handle this package as a replacement rather than a direct dependency update. This approach matches what was done in Fix #0 where helm.sh/helm/v3 was moved to the replaces parameter. The format for the replaces parameter is This change allows the build to proceed without failing on the missing dependency while still ensuring that the desired version (v1.2.6) is used during the build process. Click to expand alternative approachesAlternative Approaches
Was this comment helpful? Please use 👍 or 👎 reactions on this comment. |
Signed-off-by: Francesco Bartolini <francesco.bartolini@chainguard.dev>
cert-manager-cmctl/2.2.0-r1: fix GHSA-557j-xg8c-q2mm
Advisory data: https://github.com/wolfi-dev/advisories/blob/main/cert-manager-cmctl.advisories.yaml
"Breadcrumbs" for this automated service