Skip to content

Conversation

@octo-sts
Copy link
Contributor

@octo-sts octo-sts bot commented Sep 20, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr openrc labels Sep 20, 2025
@octo-sts
Copy link
Contributor Author

octo-sts bot commented Sep 20, 2025

🩹 Build Failed: Patch Application Failed

Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. Hunk #1 ignored at 171. 1 out of 1 hunk ignored -- saving rejects to file src/start-stop-daemon/start-stop-daemon.c.rej

Build Details

Category Details
Build System melange
Failure Point patch step applying start-stop-daemon-help.patch

Root Cause Analysis 🔍

The patch 'start-stop-daemon-help.patch' has already been applied to the source code or conflicts with existing changes. The patch system detected that the patch was either previously applied or reversed, causing it to fail during the patching step of the build process.


🔍 Build failure fix suggestions

Found similar build failures that have been fixed in the past and analyzed them to suggest a fix:

Similar PRs with fixes

Suggested Changes

File: openrc.yaml

  • version_update at line 3 (package.version)
    Original:
version: "0.63"

Replacement:

version: "0.63.1"

Content:

Update package version to latest upstream release
  • commit_update at line 20 (pipeline.git-checkout.expected-commit)
    Original:
expected-commit: e50e4a8189fd9f58c28343da7fee4f1ee47fe6f1

Replacement:

expected-commit: [latest commit hash for 0.63.1]

Content:

Update expected commit to match the new version tag
  • patch_removal at line 23-25 (pipeline.patch section)
    Original:
  - uses: patch
    with:
      patches: start-stop-daemon-help.patch

Content:

Remove the patch step entirely since the fix is now upstream
Click to expand fix analysis

Analysis

Looking at the three similar patch failure fixes, I observe a clear pattern: all failures were resolved by updating the package version and removing the problematic patch that was already applied upstream. In Fix #0, metric-collector-for-apache-cassandra was updated from 0.3.5 to 0.3.6 and the collectd-download-url-fix.patch was removed. In Fix #1, ruby3.3-rubyzip was updated from 3.0.0 to 3.0.1 and gh636.patch was removed. In Fix #2, linkerd-network-validator was updated from 0.1.3 to 0.1.4 and help-feature.patch was removed. The common thread is that upstream releases incorporated the patches, making the local patches redundant and causing conflicts during application.

Click to expand fix explanation

Explanation

The fix should work because the patch failure indicates that start-stop-daemon-help.patch has already been applied upstream in a newer version of OpenRC. When patches are incorporated upstream, attempting to apply them again causes the "Reversed (or previously applied) patch detected" error. By updating to the latest upstream version (0.63.1 or newer), we get the fix that was previously applied via the patch, eliminating the need for the local patch file. This approach mirrors the successful pattern seen in all three similar fixes where version updates resolved patch conflicts. The OpenRC project actively maintains their codebase, so checking for a newer release that includes the help functionality fix is the most reliable solution.

Click to expand alternative approaches

Alternative Approaches

  • Investigate the specific content of start-stop-daemon-help.patch and verify if it's already in the current codebase, then remove only the patch without version update
  • Modify the patch file to apply cleanly against the current version if the functionality is still needed
  • Use conditional patching with version checks to only apply the patch when necessary

Was this comment helpful? Please use 👍 or 👎 reactions on this comment.

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Sep 20, 2025
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@debasishbsws debasishbsws self-assigned this Sep 25, 2025
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Sep 25, 2025
@debasishbsws debasishbsws enabled auto-merge (squash) September 25, 2025 17:05
@debasishbsws debasishbsws requested a review from a team September 25, 2025 17:05
@debasishbsws debasishbsws merged commit 42f8b74 into main Sep 25, 2025
26 checks passed
@debasishbsws debasishbsws deleted the wolfictl-27342c61-d5c9-4a84-92f2-3317e59ecd94 branch September 25, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed openrc request-version-update request for a newer version of a package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants