systemd/259 package update

[octo-sts]

Commit: 9ca433482f2281d71718718705ca8cd3bf562ad6

Note: If you need to make manual changes to this PR, apply the skip:staging-update-bot label so the reconciler won't overwrite them.

[octo-sts]

🩹 Build Failed: Patch Application Failed

Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file src/core/systemd.pc.in.rej

Build Details

Category	Details
Build System	melange
Failure Point	patch step - applying pkgconf-expose-variables-for-system-alloc-uid-gid-min.patch

Root Cause Analysis 🔍

The patch file 'pkgconf-expose-variables-for-system-alloc-uid-gid-min.patch' failed to apply to the systemd source code at line 90 of src/core/systemd.pc.in. This indicates the target file has changed since the patch was created, causing a mismatch in the expected content structure. The patch was trying to add variables for system-alloc-uid-min and system-alloc-gid-min but the target location in the file no longer matches the patch's expectations.

---

🔍 Build failure fix suggestions

Found similar build failures that have been fixed in the past and analyzed them to suggest a fix:

Suggested Changes

File: systemd.yaml

• removal at line 76-78 (pipeline section)
  Original:

  - uses: patch
    with:
      patches: pkgconf-expose-variables-for-system-alloc-uid-gid-min.patch

Content:

Remove the patch step that is failing to apply since the functionality is now included upstream

Click to expand fix analysis

Analysis

No similar fixed build failures were provided, so I cannot analyze patterns from past fixes. However, the error indicates that a patch file 'pkgconf-expose-variables-for-system-alloc-uid-gid-min.patch' is failing to apply because the target file src/core/systemd.pc.in has changed since the patch was created. This is a common issue when upgrading to new upstream versions where the target file structure has been modified. Based on the upstream changelog, systemd v259 mentions that "system-alloc-{uid,gid}-min are now exported in systemd.pc", which suggests the functionality the patch was trying to add may now be included upstream.

Click to expand fix explanation

Explanation

The patch is failing because systemd v259 has upstream changes that conflict with the patch. According to the upstream changelog, "system-alloc-{uid,gid}-min are now exported in systemd.pc", which indicates that the functionality this patch was trying to add has been implemented upstream in version 259. Therefore, the patch is no longer needed and should be removed. This is a common scenario when upgrading packages where custom patches become obsolete due to upstream adoption of the functionality.

Click to expand alternative approaches

Alternative Approaches

• If the patch content is still needed for some reason, update the patch file to match the new file structure in systemd v259
• Verify that the upstream implementation provides the same functionality and adjust any dependent packages accordingly
• If the patch contained additional customizations beyond what upstream provides, create a new patch that only includes the parts not covered upstream

---

Was this comment helpful? Please use 👍 or 👎 reactions on this comment.

[markusboehme]

Fixed s/libacl/libacl1/ in the dependencies. Now there's the test-firewall-utils unit test that will fail with:

/* test_v6 */
src/test/test-firewall-util.c:31: Assertion failed: "r = fw_nftables_add_masquerade(nfnl, true, AF_INET6, &u1, 128)" failed with unexpected error: -2/ENOENT

I traced this back to the builder kernel configuring a few required bits as modules (and modules not being present on the builder). At a minimum, those are missing:

nf_nat
nft_chain_nat
nft_fib
nft_fib_ipv4
nft_fib_ipv6
nft_masq
nft_nat

They need to become built-ins for the builder kernel. I'll add them, and potentially a few others (so we don't play whack-a-mole later on again), to the kernel config shortly.

[markusboehme]

Tested with the new builder kernel locally. Not yet deployed to Elastic Builds.

[markusboehme]

Also had to skip the test-hostname-setup unit test, as it doesn't work on the Docker Melange runner that Elastic Build uses for aarch64:

Assertion failed: Expected "unshare(CLONE_NEWUTS)" to succeed, but got errno: 1/EPERM