ci: remove wolfictl text check #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check will routinely fail until build graph completeness is guaranteed in Wolfi itself. Until then, this check is only causing noise and meaningless red Xs in wolfictl. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
xnox
reviewed
Dec 10, 2024
| --type=name \ | ||
| --pipeline-dir=wolfi-os/pipelines/ \ | ||
| --keyring-append=https://packages.wolfi.dev/bootstrap/stage3/wolfi-signing.rsa.pub \ | ||
| --repository-append=https://packages.wolfi.dev/bootstrap/stage3 |
There was a problem hiding this comment.
this should always pass if you do repository-append of packages.wolfi.dev/os; or yes just delete it.
| run: | | ||
| ./wolfictl text -d testdata/text/ | grep foo-0.0.2-r0 | ||
| ./wolfictl text -d testdata/text/ | grep bar-0.0.1-r0 | ||
| ./wolfictl text -d testdata/text/ | grep root-0.0.1-r0 |
There was a problem hiding this comment.
this should always pass, irrespective of wolfi-dev/os state.
|
Closing in favor of #1364 |
auto-merge was automatically disabled
December 10, 2024 20:04
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check will routinely fail until build graph completeness is guaranteed in Wolfi itself.
Until then, this check is only causing noise and meaningless red Xs in wolfictl.
cc: @imjasonh @jonjohnsonjr