Adding a copy button to the source view. #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
added a commit
to iree-org/iree
that referenced
this pull request
Mar 14, 2024
This adds a new `CaptureExecutableSourcesPass` that allows for capture of individual `hal.executable.variant` ops at any number of compilation stages. Unlike the `DumpExecutableSourcesPass` this does not change the original source locations in the IR and instead captures both the textual IR and the remapped locations within it of each executable export at the time the pass is run. The textual IR is stored as resources and associated with the variants through linking and made available to serialization for embedding in target-specific formats. Because this increases compilation time (generating all of the sources multiple times per executable is expensive) and bloats binaries the capture is only enabled with the `--iree-hal-executable-debug-level=3` or greater flag set (default is `=2`). As part of this PR the CPU, Vulkan, and legacy ROCM formats have been updated to store the new information and source it at runtime. This is a breaking change to the executable library binary format. I'm not quite happy with it, but it's probably good enough for the next 6mo-1yr. To make this more usable a copy button has been added to the tracy source view: wolfpld/tracy#750 Now clicking on a dispatch in the CPU or GPU timeline will show the source and the copy button can be used to get it in the clipboard. The source can then be run through `iree-compile --compile-mode=hal-executable` to generate binaries.  Fixes #15699. Closes #16223.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the button in the call stack view:
The source content data is not guaranteed to have a NUL terminator but the ImGui clipboard API requires one so a copy is performed from the source data on-demand.