4.4.0, 4.5.0 Vulnerability #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
suggested changes
Nov 1, 2020
wolfcrypt/src/ecc.c
Outdated
| return sp_ecc_mulmod_256(k, G, R, map, heap); | ||
| } | ||
| #endif | ||
| #ifdef WOLFSSL_SP_384 |
There was a problem hiding this comment.
Don't include the SP_384 code as it is not implemented in 4.1.0.
SparkiDev
approved these changes
Nov 2, 2020
SparkiDev
left a comment
SparkiDev
left a comment
There was a problem hiding this comment.
The parts I was asked to review are all good.
kojo1
added a commit
that referenced
this pull request
Jan 3, 2024
ecc_mulmod: Joye double-add ladder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSL1.3 client requires cert_vfy before finished. CVE-2020-24613, PR3171
TLS 1.3, don't allow multiple ChangeCipherSpecs. CVE-2020-12457, PR2927
ECC timing resistance CVE-2020-11713, PR2894