checkpoint_dir is a required argument #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
__init__()
of class UNetTrainer, checkpoint_dir is out of kwargs.pytorch-3dunet/pytorch3dunet/unet3d/trainer.py
Lines 89 to 92 in 5917023
The code always runs L145 if block;
if 'checkpoint_dir' not in kwargs:
.pytorch-3dunet/pytorch3dunet/unet3d/trainer.py
Lines 145 to 146 in 5917023
It causes unintended overwrite of checkpoint file.
The if sentence should be
if not self.checkpoint_dir:
or the if block should be removed.