Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment: Readme added source codes of example projects #264

Conversation

durannumit
Copy link
Collaborator

@durannumit durannumit commented Jul 17, 2024

Description

Updated the ReadMe with links to source of the example apps

Related Issues

fix: Add links to repositories in ReadMe for showcase apps

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@durannumit durannumit added the documentation Improvements or additions to documentation label Jul 17, 2024
@durannumit durannumit self-assigned this Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

README.md Outdated
@@ -95,13 +95,13 @@ for page transitions, and scrollable content within each page.
You can see how the package is used in the example apps included in the
repository by clicking the links below:

### [Coffee Maker Example](https://coffeemakerexample.web.app)
### [Coffee Maker Example](https://coffeemakerexample.web.app) - [Source Code](https://github.com/woltapp/wolt_modal_sheet/tree/main/coffee_maker)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this. Should we have One section title

Examples

Coffee Maker Example

[Web app], [Source code]

Playground Example]

 [Web app], [Source code]

and so on?
image

Copy link
Collaborator

@ulusoyca ulusoyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks!

@ulusoyca ulusoyca merged commit 5718e2c into woltapp:main Jul 18, 2024
4 of 5 checks passed
Copy link
Collaborator

@AcarFurkan AcarFurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to repositories in ReadMe for showcase apps.
3 participants